Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fw): EOF - Fix EXCHANGE's data_portion_length #849

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix(fw): EOF - Fix EXCHANGE's data_portion_length #849

merged 2 commits into from
Oct 1, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Sep 30, 2024

🗒️ Description

Just a minor issue I've noticed. It didn't affect any bytecode generation, but fixing anyway

🔗 Related Issues

NA

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz
Copy link
Member

danceratopz commented Sep 30, 2024 •
edited
Loading

Hi @pdobacz, the initial CI fail has been fixed by #850 so I merged main into this branch. Sorry about that.

marioevz
marioevz approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit ce11586 into ethereum:main Oct 1, 2024
3 checks passed
@marioevz marioevz deleted the exchange-data-portion branch October 1, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdobacz @danceratopz @marioevz